Add missing retransmissions for SYN/SYNACK/FIN segments#33
Open
danielinux wants to merge 1 commit intowolfSSL:masterfrom
Open
Add missing retransmissions for SYN/SYNACK/FIN segments#33danielinux wants to merge 1 commit intowolfSSL:masterfrom
danielinux wants to merge 1 commit intowolfSSL:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request implements retransmission logic for TCP control segments (SYN, SYNACK, and FIN) to improve connection reliability when these critical packets are lost. The implementation adds a separate control-segment retransmission timeout (RTO) mechanism that operates independently from the existing data-segment RTO, using exponential backoff with a configurable maximum retry limit.
Changes:
- Added TCP control segment retransmission with separate RTO tracking (ctrl_rto_active, ctrl_rto_retries)
- Implemented exponential backoff for control segment retransmissions with a maximum of 6 retries
- Enhanced tcp_rto_cb to handle SYN_SENT, SYN_RCVD, FIN_WAIT_1, and LAST_ACK states
- Updated FIN acknowledgement detection to properly check for sequence number wraparound
- Added comprehensive unit tests covering retransmission scenarios and edge cases
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/wolfip.c | Added control RTO infrastructure, timer management functions, updated tcp_rto_cb to retransmit control segments, enhanced tcp_ack to detect FIN acknowledgements and stop control timers, initialized control RTO state in connect/close paths, prevented data RTO interference with control states |
| src/test/unit/unit.c | Added tests for SYN/FINACK retransmission, SYNACK cancellation, FIN_WAIT_1 transition, retry cap enforcement; corrected existing test to use seq+1 for FIN ACK; updated non-established test to use TCP_CLOSED instead of TCP_SYN_SENT |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.